simstudy icon indicating copy to clipboard operation
simstudy copied to clipboard

Allow alternative distribution names

Open assignUser opened this issue 5 years ago • 6 comments
trafficstars

  • bernoulli as "standard" alternative to binary
  • gaussian as "standard" alternative to normal

assignUser avatar Oct 28 '20 14:10 assignUser

I am not sure about this one, there is quite a bit of code dependent on the names other than just the generate stuff, so there is a large potential for introducing errors now and down the line.

~~Maybe a better approach would be to add the names to the documentation~~ That is already the case with the new overview vignette.

Let me know what you think.

assignUser avatar Oct 29 '20 07:10 assignUser

I am not saying this is the most crucial thing, but what if we just added two new distributions that happen to act just like two existing distributions? So, we wouldn't break anything internally.

kgoldfeld avatar Oct 29 '20 12:10 kgoldfeld

that would not really change anything^^ The issue is not with integrating the new distribution names in the generate chain, that's rather easy. But there are a quite a few checks like this spread around that we would also need to adjust: image

assignUser avatar Oct 29 '20 12:10 assignUser

But what if I said we want to introduce a new distribution, say the Weibull distribution - would you make the same argument?

kgoldfeld avatar Oct 29 '20 13:10 kgoldfeld

In a way you are right, I will check out what the dependencies are exactly and think about how to best proceed.

assignUser avatar Oct 30 '20 07:10 assignUser

This is another issue that would benefit from the switch to r-expressions #75 as these dependencies I mention here would basically all go away,

assignUser avatar Jul 08 '21 20:07 assignUser