Mojtaba Samimi
Mojtaba Samimi
Excellent. Now please download the `baselines.tar` from the `artifatcs` tab of `test-baseline` test here: https://app.circleci.com/pipelines/github/plotly/plotly.js/10578/workflows/3582843f-823a-45b2-9d65-3eff4281d1be/jobs/232240/artifacts And extract the files and replace the PNGs inside `test/image/baseline` folder; then commit and push.
Excellent. It looks like parts of the changes to the baselines in 7cd3177 are coming from the changes you made to the `test/image/mocks`. Now let's investigate what would happen if...
> They are reverted now, but it won't be pretty as those mocks use the hardcoded mapbox style keywords like "outdoors", "satellite" and "basic" that doesn't mean anything anymore.. so...
> if some existing user has written "light" (a mapbox style), we can at plotly.js level in the file i linked above have that mean the same as i.e. "carto-positron"...
> I think it might be easier to to just add the missing keywords `'basic', 'streets', 'outdoors', 'light', 'dark', 'satellite', 'satellite-streets'` to this object: > > https://github.com/plotly/plotly.js/pull/7015/files#diff-4c999e79e2db6d26fdc437b32284ecb9cf566c275e50c56ad8946b1405e1b27fL29 Good call. :100:
Please fetch `upstream/master` and merge it here. Then please investigate the baseline changes in the failing tests. Thank you!
Please resolve the conflicts in this PR. Thank you!
That looks interesting. Looking forward to reviewing your PR.
@VladimirKondratenko Have you tried `tickmode: "linear"` and setting `tick0` to desired time?
Right now if I set `minscale` and maxscale` to 1, I expect the graph not to be scaled. However, using `wheel` scroll zoom the scale changes once. To fix that...