plotly.js icon indicating copy to clipboard operation
plotly.js copied to clipboard

[PATCH] Improvement for logarithmic scatter axis tick labels, avoid overlapping text

Open jensb opened this issue 3 years ago • 4 comments
trafficstars

Hello,

I created a patch for Plotly which impvoes display of axis tick labels for logarithmic axes of scatter plots. More preciesly, it avoids overlapping labels much better (IMHO) than before.

The issue and the patch is described in more detail here: https://stackoverflow.com/questions/70926979/skip-overlapping-tick-labels-in-plotly-javascript/70953790#70953790

Do you think this has a chance to be merged? Then I'll create a PR for the master branch. If this needs more work, please advise.

Thank you!

jensb avatar Feb 04 '22 08:02 jensb

That looks interesting. Looking forward to reviewing your PR.

archmoj avatar Feb 07 '22 15:02 archmoj

Sure! However, I need to ask for some assistance.

I set up the devel environment and I can run npm start to boot up. But on the first Tabs.reload() I get a syntax error in plotly.js. This is the offending line:

image

This is how the line looks after the first Tabs.reload():

image

There seems to be a charset issue in the reload feature. What am I doing going wrong?

I'm using Chrome 98.0.4758.80 on Linux, as well as NPM 8.3.1, Node 16.14.0.

jensb avatar Feb 15 '22 10:02 jensb

I managed to patch Plotly anyway: https://github.com/plotly/plotly.js/pull/6120

jensb avatar Feb 15 '22 19:02 jensb

Any comments, progress, review? Anything I need to do to help merging this? Yes, there are some failing tests, but this is obviously because I am (slightly) changing Plotly's behaviour, intentionally ... for the better, I hope.

jensb avatar Mar 09 '22 17:03 jensb