Mojtaba Samimi

Results 241 comments of Mojtaba Samimi
trafficstars

> > @stephprobst Do you have a use case for adding these options to selections? If no, I'd suggest not to implement it in this PR. > > @archmoj: No....

Thanks for the simplification. Please update the PR title and description. Also `zzz_shape_shift_vertical` image test is failing now.

@stephprobst Do you have a use case for `date` axes? If so it could be possible to add these options for other axis types.

When `shape.editable` is set to true, clicking the shape and editing the position of a vertex result in the wrong positioning of the updated shape.

Please also test `texttemplate` on your mocks to show the slopes similar to those in the `text_on_shapes_texttemplate` mock. Thank you!

> Failing mapbox test appears to be unrelated to my changes. It looks good locally. To fix it, please fetch `upstream/master` and merge it into this branch. Thank you!

Looking good to me. I ask @alexcjohnson and @LiamConnors for their reviews as well as approving the attribute names and descriptions. Thanks.

> The mapbox PR was already merged before, see here: [4ccaf73](https://github.com/plotly/plotly.js/commit/4ccaf7381592e719ff31c3947e0765fed984aa70) It's no longer the `mapbox` test which is failing. The image test I rerun from start and it passed....

> it('should be able to restyle radial axis title', function(done) { Thanks for testing out. Please add `@flaky ` tag to the start of test description like this: ```js it('@flaky...

I think this could also help resolve #1673. :tada: which is one the oldest open issues now. Please add `Resolves #1673` to the PR description. Thank you!