Mojtaba Samimi

Results 319 comments of Mojtaba Samimi
trafficstars

Please revert [6ea832f](https://github.com/plotly/plotly.js/pull/7006/commits/6ea832f426a1b6b32645803588ae7c020b78524b) then fetch `upstream/master` and merge it into this branch so that the CI tests pass. cc: #7030.

I like the attribute names. But @LiamConnors what do you think of new attribute names here? cc: @emilykl

> I wonder if it would be more intuitive to specify this as something like `ticklabeloffset: {x: 20, y: 10}` ie a number of pixels to move the labels in...

I checked with @LiamConnors and @emilykl and they both suggested to use `ticklabelshift` instead of `ticklabelrunoff`.

@my-tien This PR is looking very good. @stephprobst Do you want any specific figure to be tested in this PR?

@my-tien Just few fixes needed by you here (see my recent comments) and we should be good to merge it today!

@my-tien the mapbox baseline failures are fixed in #7019. Please fetch upstream/master and then merge master into this pull request as well as into other PRs.

Getting closer. Could you please investigate why the `legendgroup` mock renders differently compared to master?

@my-tien Would you please fetch `upstream/master` and merge it into this branch?

@my-tien Would you please fetch upstream/master and merge it into this branch again? We are thinking to possibly include this feature in v3.1.0. Thank you!