Mojtaba Samimi
Mojtaba Samimi
@my-tien Please resolve the conflicts with master on this branch. Thank you!
> Thanks for the feedback! > > Yes, finding a name is one of the more difficult problems of this PR and any help is welcome! > > If we...
@my-tien Just a few comments to address and we should be good to merge this PR. :star2:
Could you please provide a fix so that the extra bold render on `mapbox_fonts-supported-open-sans` mock?
> > Could you please provide a fix so that the extra bold render on `mapbox_fonts-supported-open-sans` mock? > > I can add the patch from the other PR that makes...
Now let's add `'mapbox_geojson-attributes'` and `'mapbox_layers'` to the blacklist here. https://github.com/plotly/plotly.js/blob/7c22d2f988446fabbdbfe3e304789e3045d72ecf/test/image/make_baseline.py#L97-L102 For now this would help we have a successful baseline creation and then the image comparison test would start...
You also need to fix rendering of `mapbox_fonts-supported-open-sans`. Thanks!
Almost there. Let's also blacklist these mocks for now. Later we will investigate why they are failing. ``` 'plot_types', 'trace_metatext', 'zz-gl3d_surface_small_timerange', ```
OK. Let's watch which one fails on the CircleCi now.
No! By looking at failures of different parallel runs I think the blacklist should include the following now: ```js [ 'mapbox_stamen-style', // TODO: figure out why? 'plot_types', 'trace_metatext', 'zz-gl3d_surface_small_timerange', ]...