Wuzzy
I feel like the `rotate` argument is better added as a separate argument (and renamed accordingly), rather than mixing it into the `selectionbox` argument. Mixing numbered with named indexes always...
Whatever, my opinion on that is not very strong anyway.
Sadly, my code already includes a workaround which depends on this behavior (by playing the missing sound manually) so changing it would break my code. :-( But if this is...
Hardcoding core setting default values into Lua is a terrible idea, modders should not be forced to do this. This has nothing to do with convenience.
> Putting this specifically into a scriptapi feels like the wrong place. > Isn't there a function in nodedef.cpp that deals with compatibility like this? Maybe it's time to create...
The “texture fill-in algorithm” is this one: ``` if (i >= 1){ TileDef lasttile = f.tiledef[i-1]; while (i < max_i){ f.tiledef[i] = lasttile; i++; } } ``` It's in `src/script/common/c_content.cpp`...
Is there anything else blocking this PR?
To clarify: To me, this PR looks perfectly fine and I don't know what else to improve/fix. I probably won't touch this PR without further review.
I tested this, and it introduces a bug. If you build a straight rail, at one of the ends, the rail texture will be flipped (watch the red dot). This...