Chris Ross

Results 449 comments of Chris Ross
trafficstars

@dajma00 you'll also need to include the keys file: https://resources.infosecinstitute.com/topic/decrypting-ssl-tls-traffic-with-wireshark/

Please address the compilation error. > src/Shared/HttpSys/RequestProcessing/RequestHeaders.cs(105,16): error CS0102: (NETCORE_ENGINEERING_TELEMETRY=Build) The type 'RequestHeaders' already contains a definition for 'Count'

> Open question: should we consider re-implementing ContainsKey to gain performance benefits? You're welcome to try.

> RequestHeader.Generated.tt is updated, however it does not seem be set up to generate the RequestHeader.Generated.cs file. See https://github.com/dotnet/aspnetcore/pull/44860#issuecomment-1318233600

FYI: https://github.com/dotnet/aspnetcore/pull/45250

Have you rebased on https://github.com/dotnet/aspnetcore/pull/44860 yet? It has new infrastructure that might be helpful here.

This may have caused a regression in the following test: https://dev.azure.com/dnceng-public/public/_build/results?buildId=96807&view=ms.vss-test-web.build-test-results-tab&runId=2055890&resultId=100028&paneView=debug Investigating.

Nevermind, the new error is related to hostfxr even trying to load the app, that shouldn't be related to any changes here. This was just the first occurance.

> Remove supportsMultipleValues parameter from CookieHeaderParserShared.TryParseValues() method to prevent parsing strings wrong (partly) which contain separator characters. I don't think this is the right aproach, it seems to have caused...