Chris Ross
Chris Ross
The UnhandledException log is not the one that emits the end-of-response data like status code. However, this is where we check HasStarted and decide if we should change the response...
@singh733 we'd also want to ensure that the OperationCancelledException was caused by the request aborting and not something else. See the discussion starting at https://github.com/dotnet/aspnetcore/issues/44697#issuecomment-1289621220 `_logger.UnhandledException(ex);` could be conditional based...
You mean there's no OperationCancelledException catch statement now? Yes, you'll need to add those. You won't be working with BadHttpRequestException.
Does `operationCanceledException.CancellationToken == context.RequestAborted` work if a linked cancellation token caused the failure? If not, `if (ex is OperationCanceledException operationCanceledException && context.RequestAborted.IsCancellationRequested)` might be the best option. You should `return;`...
> `if (ex is OperationCanceledException operationCanceledException && operationCanceledException.CancellationToken.IsCancellationRequested)` I think you missed the point here. `operationCanceledException.CancellationToken.IsCancellationRequested` should always be true when catching an OperationCanceledException. What we want confirm is if...
The discussion around model binding is about control flow. Model binding is doing IO from Streams which can only report errors by throwing IOExceptions. Since these are expected from Streams,...
@sebastienros who's read up on these more recently...
I don't see any indication in the spec that max-age needs to be specified. There's even a whole section about heuristically calculating a cache duration if one is not specified....
Yeah, we should be treating max-age and no-cache as separate concerns. Anywhere a user sets duration we should use it, but if they don't, oh well.
With chrome logs enabled I see one related error. `"C:\Program Files (x86)\Google\Chrome\Application\chrome.exe" --enable-logging=stderr --v=3` `[10772:14408:0629/112726.774:WARNING:spdy_session.cc(3273)] Received RST for invalid stream7` Stream 7 was the WebSocket stream and this RST is...