Chris Ross

Results 449 comments of Chris Ross
trafficstars

Oh, I thought you were referring to a fix for this issue. This issue should still be fixed regardless.

> + ValueTask TryWriteAsync(ProblemDetailsContext context, out bool result) Async APIs can't have out parameters. One other alternative: IProblemDetailsService.CanWrite(ProblemDetailsContext ) that mirrors IProblemDetailsWriter

The middleware is designed for cooperative timeouts, not forceful ones. E.g. when the timeout fires it's not going to call Thread.Abort or anything, that ends up being too destabilizing. What...

This is a huge breaking change that's just not going to happen. At best you'd get an incompatible fork with no interop between them. Since you wouldn't be able to...

You touched it last 😆

Getting access to the AuthenticationTicket would address this without requiring modification of the principal. It could be cached in the auth feature? Note that AspNetCore often does not directly create...

Do we know if any clients that actually use request body compression and are currently broken?

At least the tests fail as expected 😁 (you'll need to update those)