Chris Ross

Results 449 comments of Chris Ross
trafficstars

This was updated in https://github.com/dotnet/aspnetcore/pull/45362, including the needed test. Thanks.

Ah, hopefully thus preventing WebApplicationBuilder from adding duplicates?

Once you have the dump, open it in VS and look at the threads window for blocked threads, and the parallel tasks window for blocked tasks. That should give you...

StartNew is fine. _bufferPauseEvent.WaitOne() isn't great. What unblocks that event? There are async structures you can use to avoid blocking the thread, like SemaphoreSlim, Channels, ConcurrentQueue, etc.

Bedrock works at a layer lower than HTTP and WebSockets, focusing mainly on the transport (TCP, TLS), I don't know how applicable that is here. @davidfowl

Cookie was intentionally excluded from RequestHeaders due to its sensitive nature. Moving it out of that if block would be the correct fix.

Are you interested in submitting a PR for this?

Can you capture a decrypted wireshark trace?