Chris Ross

Results 446 comments of Chris Ross

- Why did you move your retry middleware out of MapReverseProxy? You'll want it inside there to get full access to proxy features. - You need to rewind the request...

Much better. A few more suggestions (coding in the browser, may not compile 😁): ```c# public class RetryMiddleware { private readonly RequestDelegate _next; public RetryMiddleware(RequestDelegate next) { _next = next;...

Oh, I didn't know the binder removed matched values from the collection. That's not great. Can you please make a separate issue for that? We don't want the transforms to...

The other reason we'd avoid POST is that it would require buffering every request body. That's more overhead than we'd want to introduce. Since most aren't safe anyways, that shouldn't...

Here's the actual check for that error: https://github.com/microsoft/reverse-proxy/blob/c6643100e1b5cde125a9ea4b95c10adc7b386dd0/src/ReverseProxy/Forwarder/RequestUtilities.cs#L419-L423 I suggest calling HttpResponse.Clear() before retrying. SuppressResponseBody prevents the body from being proxied, but the status and headers are still copied and...

Replaced by https://github.com/Azure/azure-cli-extensions/pull/8677