Cristian Le

Results 853 comments of Cristian Le
trafficstars

@happz There are no other PRs that could help with the tests for this right? The [failed test](https://artifacts.dev.testing-farm.io/a005ffca-4f45-464f-b1ea-30bd1f20b3af/) is very bizarre to me, i.e. where is the fmf root detected...

Anyway, I have added the tests for the fmf_root. Can someone trigger the tests again?

Makes sense, so the issue is that my wrapper here still detects the current path's `.fmf/version` even though it is not added. I don't get how the the previous version...

> I'm afraid that it can be false positive - If the 'path' is set to say `gitroot/foo/bar` but fmf root is only in `gitroot/foo` the fmf.Tree call will find...

Ok, 710433738e582427f5cba5296faeda531eba4745 should fix the issue. Am I missing anything else?

Yey, tests are passing :)

I see that I need to include the `--falied-only` flag to the pre-commit (done). But other than that anything else needed for this PR?

Quick question. Should I remove `--failed-only` flag if either `--verbose` or `--debug` are passed, and if so at which level? Or is it already handled internally?