Cristian Le

Results 855 comments of Cristian Le
trafficstars

Indeed @lukaszachy @happz can someone put a milestone on this one so we can fix this already?

> We need nicer exceptions. Good point, we could definitely add it. Should it be forwarding stderr and `exit(1)`, or handle commands more specifically? > Some empty lines got deleted,...

@happz Ok, here is the simpler variant. Ended up longer than 3-4 lines because of comments :grin: (also filtering out filenames because it is expected to pass thousands of file...

> /packit test These days I think /packit build and test must be done separately. At least I've seen that for manual triggers

Indeed, if it was such a simple fix, I would have made a PR with the feature. If we can create a simple wrapper I think it's trivial, but otherwise...

I did a bit of quick testing, and there is a more crucial issue that `tmt --root path/to/fmf_root lint` fails: ``` fail No tree found in repo 'None', missing an...

I have tried with both `1.21` and `1.22`. Try with this minimal example plan and with a git repo: ``` summary: simple example discover: how: fmf filter: "tag: something" execute:...

@lukaszachy Let me know if you can confirm this behaviour

Ok, separated in #2006

As for the `pre-commit`, I've tried a hack as: ```yaml - id: tmt name: tmt entry: tmt files: '.*\.fmf$' verbose: true pass_filenames: true language: python language_version: python3 ``` and ```...