Cristian Le

Results 893 comments of Cristian Le
trafficstars

No idea why pre-commit decided to fail in this PR, maybe it runs on different files in a commit vs merge. Anyway patched those up in this PR

That would work for `testing-farm`, but what about local runners with `provision.how = local`, or even with `provision.how = container`. Manual runs would not set context, so shouldn't that affect...

Oh wow, this is what it expanded for me: ```rst * Verified by `/tests/core/adjust `_ ``` It seems the generation automatically puts in the git repo and branch, but then...

> With #3001 applied, I get no broken links reported from the linkcheck builder. Let me rebase on your commit first just to make sure it works for forks as...

Hmm, but looking at the original generated links it actually looked fine: ```rst * Verified by `/tests/core/adjust `_ ``` It points to a correct file, so should it actually have...

Sorry, should have done this long ago, let's what exactly is being produced in github action: https://github.com/teemtee/tmt/actions/runs/9450580783/artifacts/1585890004 ```rst * Verified by `/tests/core/adjust `__ ``` It is literally `None` :sweat_smile:. Seems...

Oh, yeah, I didn't even realize the normal build actually worked perfectly fine. One difference is that `hatch` is used for the Github actions. Oh, and python version. Another hypothesis,...

Ok, I probably have a clue: ```rst .. [Debug] emit_tmt_object_links(link).object = /tests/core/adjust [Test] fmf_id.url = https://github.com/teemtee/tmt fmf_id.ref = None ``` It's probably that `actions/checkout` on PRs is pointing to the...

Maybe, it's more simple than that, just the command failing at: ```python branch = run(Command("git", "rev-parse", "--abbrev-ref", "--symbolic-full-name", "@{u}")) ``` Maybe there are better commands than `rev-parse` to get what...

@happz checkout 94fc226ca5d757ff63052119477fc57712068152 and b9d84acab0ced825e8e4b62ce131b4add431f6f0 if you've got time. This almost works, just need to sanitize `web_git_url` a bit more to be able to read and navigate `ref=refs/remotes/pull/N/{merge,head}` (and equivalent...