Cristian Le

Results 920 comments of Cristian Le
trafficstars

> Yeah, but that's demonstrating the problem right away :) When I drop the inner type, and run mypy with Pint 0.19.2, which is a perfectly valid version, mypy starts...

Lol, I like it how `PyRight` is contradicting itself ``` /home/runner/work/tmt/tmt/tmt/hardware.py:544:20 - error: Unnecessary isinstance call; "Quantity" is always an instance of "Quantity" (reportUnnecessaryIsInstance) /home/runner/work/tmt/tmt/tmt/hardware.py:545:25 - error: Expression of type...

I'll rebase when #2742, and if all goes well, we can delay this for after #2557 to make sure we don't have any surprises. Seems neither `pyright` nor `mypy` can...

> This sucks, and I would hate to use Any :( We still have to live with older Pint versions, and newer ones seem to be too incompatible on this...

> A lot, I would say, because mypy and pyright are not just about type checking, they also detect attributes that are not defined, for example. Most tmt users depend...

> Could we add some testing-farm installing from pipy? Maybe a weekly/nighly just to check what are the latest pypi versions and how we work with them? Let's wait for...

Right now I've disabled pyright: ``` /home/lecris/PycharmProjects/tmt/tmt/hardware.py /home/lecris/PycharmProjects/tmt/tmt/hardware.py:562:25 - error: Expression of type "PlainQuantity[Any]" cannot be assigned to declared type "ConstraintValue"   Type "PlainQuantity[Any]" cannot be assigned to type "ConstraintValue"     "PlainQuantity[Any]"...

Maybe a more relevant issue, there should be a test that actually covers `Size`. My inclination is to simply test that `tmt show` is rendered equivalently on all, but maybe...

Seems xarray could be blocked by this. There seem to be [unit tests](https://github.com/teemtee/tmt/blob/main/tests/unit/test_hardware.py) for hardware, so how about rebasing and adding this to pyright/mypy ignores?

Tested locally, unit tests and mypy pass, so only pyright is tripping it. I've just added some ignores there to get the testing working. Can anyone do some magic `/packit`...