Cristian Le
Cristian Le
Should document that now the full name with `prefix::` is used for regex filter. Also I don't see a mention in the tests about `TMT_TEST_NAME`. Should make sure that is...
Is the plan to implement a `prepare.how: keep-git-metadata` step after which the fmf tree has the same `.git` metadata with whatever changes are added before/after this step?
You can navigate to them in the `coverage/*` github workflows. For example: https://app.codecov.io/github/spglib/spglib/commit/de7497cecdc744944e9277726b8f5fe6888ac37b/tree/python Here there are no python related coverage reports
But PRs from forks to main repo have access to the main repo's secret so it will be using that token. The difference would be if they are making a...
> > But PRs from forks to main repo have access to the main repo's secret so it will be using that token. > > @LecrisUT No, [they don't](https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions#using-secrets-in-a-workflow). They...
Regarding "Contribution License Agreement" I am unclear on what is being targeted there? Is it solely the commits on this repo, or are they referring to the package's source code...
@microsoft-github-policy-service agree
> usage: Modern CMake design is to use `FetchContent` and rely on `FIND_PACKAGE_ARGS`. `spglib` was converted to allow this modern workflow. What do you think about advertising that? Regarding fortran....
Should I separate the blocks a bit there, maybe like: ``` spglib provides CMake targets: find_package(Spglib CONFIG REQUIRED) target_link_libraries(main PRIVATE Spglib::symspg) spglib is also compatible with modern CMake workflows include(FetchContent)...
> Your FetchContent implementation may be excellent, but that approach really doesn't integrate well with vcpkg's effort to control version, configuration and ABI. What I am trying to say is...