Cristian Le

Results 912 comments of Cristian Le
trafficstars

> cibuildwheel is not default config: Ak didn't see the images there > Also, you don't need most of the skips Yeah there's a bunch of stuff to go through...

Weird it did not get picked up :/. I guess otherwise `Failed to load lib` is a red-herring?

Checking up on this PR, still blocked on the implementation?

That's a fundamental CMake design question. If you are ok with minimum CMake 3.25, the recommended approach is: ```cmake # CMake boilerplate to define your project cmake_minimum_required(VERSION 3.25...3.30) project(My_Project) #...

You should add `target_include_directories` as well. Should point out that `talib` build system is **horrible** you should not be needing to use such an approach, but alas that is not...

Sure, I can give a re-review. I of course picked up a lot of design practices since this PR and there are aome minor details that I would change. The...

Looking at the changes made, I believe we can still do piecewise changes, e.g. chainging the CI, adding higher bound policy, etc. We should start over this one imo. I...

> When I understand it correctly you want to be able to document cmake files and present them in a way doxygen does. Indeed that's the case. We cannot map...

Ok, I will make a small example project to mock-up these, but conceptually here is a short snippet of what I am referring to, just so we can confirm we...