Justin Moore

Results 146 comments of Justin Moore
trafficstars

To add to this discussion - `gdbstub`'s `RegId` abstraction does not allow for dynamic dispatch due to `RegId::from_raw_id` returning both an ID and size, the latter of which cannot be...

Sure! I'd be happy to put in some work to improve this API :) I like your suggestion of providing a size hint via an `Option` return value. I suppose...

Also - I noticed that there is a new `pc()` function on the `Registers` trait. It doesn't appear to be used at this point, but for obvious reasons it isn't...

Overall the API is a delight and painless to use. I'm using this library as a frontend to an emulator and learning Rust at the same time, and this is...

I appreciate the detailed write-up! I'll have to take a look at implementing a passthrough like you described. You're right that it's not ideal for users to know the layout...

Ah - you have some really good points! I'm still learning a lot about the language, and it's easy to think "ah, well I can just do it the way...

Another thing that recently came up - the implementation of `resume` for `MultiThreadOps` (and this may apply to `SingleThreadOps`) is somewhat easy to implement incorrectly. It's provided an iterable list...

Here is the relevant target description file from the GDB sources for PPC32: https://github.com/bminor/binutils-gdb/blob/master/gdb/features/rs6000/powerpc-32.c

Appreciate the other references :) I have a PPC target, but I'll have to figure out the dynamic dispatch first before I can test a `RegId` implementation for it.

Yeah - it does raise some awkward questions. I would want to pull in indices and it'll get a bit complicated because the buffer contents window is "separate" from the...