Benjamin Rodenberg

Results 238 comments of Benjamin Rodenberg

@fsimonis do you think we should still keep this issue open? I don't have an overview over C and Fortran. For python this issue is definitely solved. For the other...

As long as using the deprecated `Rbf` function does not cause trouble I would keep it as it is and prioritize the development of the FEniCSx adapter and especially the...

@NiklasVin is this issue related to https://github.com/precice/fenics-adapter/issues/194 ? If yes: let's keep both issues as a `wontfix` but this gives us a hint for a possible solution.

Note that the implementation of communication for different coupling schemes without introducing a considerable amount of code duplication was relatively complex. One (API breaking) possibility how we could improve this...

We should also collect side-effects of this change here. @fsimonis mentioned that some postprocessing tools might break. Let's create a list of affected tools here.

@fsimonis maybe a candidate for a coding days hackathon?

Regarding API implementation: One idea that came up during the workshop was to pass (for example) `nan` in the write data function to mask the corresponding vertex as disabled. If...

Depending on what you are doing you might even want duplicate vertices. See https://precice.org/couple-your-code-distributed-meshes.html. Therefore I think it's a good idea to make this check configurable. > Does it suffice...

@kss682 can you explain a bit more about why you need this fixed? I'm just asking because maybe I'm missing some technical detail in your use case. I agree: It...

A list of open ToDos: - [x] https://github.com/precice/tutorials/tree/develop/channel-transport-reaction/chemical-fenics - [x] https://github.com/precice/tutorials/tree/develop/channel-transport-reaction/fluid-fenics - [x] https://github.com/precice/tutorials/tree/develop/elastic-tube-1d/fluid-python https://github.com/precice/tutorials/pull/564 @MakisH - [x] https://github.com/precice/tutorials/tree/develop/elastic-tube-1d/solid-python https://github.com/precice/tutorials/pull/564 @MakisH - [x] https://github.com/precice/tutorials/tree/develop/elastic-tube-3d/solid-fenics - [x] https://github.com/precice/tutorials/tree/develop/flow-around-controlled-moving-cylinder/solid-python - [x] https://github.com/precice/tutorials/tree/develop/flow-around-controlled-moving-cylinder/controller-fmi...