Benjamin Rodenberg

Results 248 comments of Benjamin Rodenberg

The intended use of the adapter is one interface. In certain situations more than one interface might be needed, but I don't really see the need for this feature now....

I totally misunderstood the issue. We are talking about `coupling_subdomains`, not about what we call the `interface` in the adapter: https://github.com/precice/fenics-adapter/blob/87e03f8ec169fad7c4d19f73a9a6bd3db9244e66/fenicsprecice/fenicsprecice.py#L267-L268 https://github.com/precice/fenics-adapter/blob/87e03f8ec169fad7c4d19f73a9a6bd3db9244e66/fenicsprecice/fenicsprecice.py#L57 This is, of course, a totally valid use-case....

@NiklasVin I think this is mainly a documentation issue that we can resolve by updating the `README.md`. For more recent `pip` version it is generally recommended to use `venv` (we...

I did not know that the coupling iterations are that sensitive. From my personal experience checking the number of iterations was quite useful in the past. [Here](https://github.com/precice/fenics-adapter/pull/81#issuecomment-671786638) it allowed us...

This feature is (at least partially) implemented in the current version of the adapter: https://github.com/precice/fenics-adapter/blob/1ccab476e3923b34daf274e365ad777f9411569f/fenicsadapter/fenicsadapter.py#L514-L529 However, I think we should also have an example, where one can see how to...

I just discovered that the link provided above seems to be broken. What I was referring to is [the example in chapter 4.3 "Defining subdomains for different materials" in the...

The FEniCS-X version of this tutorial is provided at https://jorgensd.github.io/dolfinx-tutorial/chapter3/subdomains.html.

Hi @mmichelis! The warning is raised at this place: https://github.com/precice/fenics-adapter/blob/102022d5c3cdd6452bb0b5ab3900d20ec8508bca/fenicsprecice/adapter_core.py#L141 Some history about the warning can be found here: https://github.com/precice/fenics-adapter/issues/90 I think we should definitely improve this warning, because at...

You can use python bindings `v2.3.0.0` with preCICE `v2.5.0`, but you will miss some features that might exist in preCICE `v2.5.0` if there was no corresponding API already in python...

A remark from my side: As a first step I would suggest to change the following section of the code: https://github.com/precice/python-bindings/blob/6de8993bfce6cc071a6a9965b193694cd92d968e/.github/workflows/build-docker.yml#L35-L44 We did a pre-release that succeeded and only when...