Benjamin Rodenberg

Results 238 comments of Benjamin Rodenberg

Just had a phonecall with @ajaust. I'll try to summarize my thoughts here: `precice/_version.py` is generated by `versioneer` by using a [template](https://github.com/precice/python-bindings/blob/f3b5761ce3047b56fe5dc294347efaffdee59b73/precice/_version.py#L20-L30) provided in the repository. As far as I...

There is already an issue for this problem in the versioneer repository (https://github.com/python-versioneer/python-versioneer/issues/217). We will go for solution 2. proposed above, which is also proposed here: [in this comment](https://github.com/python-versioneer/python-versioneer/issues/217).

I added 44b715d on `master` to make sure that the hash for `v2.3.0.1` will not change anymore: I did a quick experiment locally with the tar balls of the release:...

@ajaust do you think we can close this issue now?

In https://github.com/precice/python-bindings/pull/206 the checksum changed again for unclear reasons.

Since checksums of the latest release keep changing: We could extend the CI to call `./spack checksum --verify -l py-pyprecice` regularly.

We could have a `precice_noop` and just do ``` import precice_noop as precice ``` this would keep the python bindings clean and it still handles your use case. Not sure...

> Another [code example](https://github.com/IshaanDesai/coupled-heat-conduction/blob/main/macro-heat-cond.py) why this feature is needed Can you elaborate or point to a more specific place? Looking at the code I don't directly see the reason (I...

I tried building the spack base image, but ran into trouble with building boost, when building locally via `docker build -t external-deps -f spack/ci-spack-pyprecice-external-deps-2004.dockerfile .`: ``` ==> Installing boost-1.77.0-ih2n3iejl2kufyybakahhq4tottejwer ==>...

I totally agree. I at least cannot remember any real "reasoning" behind picking the term `Interface` over `SolverInterface` (which would be the reasonable default). Probably it was just always `Interface`...