0b5vr

Results 111 comments of 0b5vr
trafficstars

Ready to merge! We are going to bump the major since the breaking change occurs.

日本語で恐縮ですが、NodeMaterialを継承したマテリアルのコードを読む上で、NodeMaterialの動作の流れ(r164現在のもの)を以下のページにまとめてあります。レビューの際にご活用ください。 https://scrapbox.io/0b5vr/Three.js:_NodeMaterial

> The rendering result differs when there is no texture and only a normal map. It seems to be, yes! The blue ball in the example should have bumps on...

Resolved conflict with `dev-v3`, it's now ready to build using esbuild. I don't have to explicitly specify `three/addons/nodes/Nodes.js`, esbuild seems to handle this by only specifying `three`.

> If possible, please incorporate this change. [25cc2ba](https://github.com/pixiv/three-vrm/commit/25cc2ba3f40c0f80d7da4a51a8e4cd84dc0a79ab) yes I have to indeed

> > If possible, please incorporate this change. [25cc2ba](https://github.com/pixiv/three-vrm/commit/25cc2ba3f40c0f80d7da4a51a8e4cd84dc0a79ab) > > yes I have to indeed done @ https://github.com/pixiv/three-vrm/pull/1384/commits/36f064fb7653920ec4ff3bf453ac478ba08432dc

`MToonNodeMaterial` is gonna be compatible only with r161 or higher. I added a warning if the user attempts to use this in r160 or before. https://github.com/pixiv/three-vrm/pull/1384/commits/afe9143d2054097c1b99aae876a77d4bbe58c38c

実はFirefoxとChromeで挙動違ったりとかなかなか難しいです、頑張ります

今触ってみたらFireFoxで全く正常に表示されてないじゃん!!だめじゃん!!!

lack of instruction, right. I'm sorry. I still have to hear whether there are error on console or not. if so, please send me the detail of your environment.