Julius Žukauskas

Results 65 comments of Julius Žukauskas

There is some issue associated with combination generation in non multishop context and then turning the multishop on (it seems that way combinations are missing in product_attribute_shop). While i tried...

should rebase instead of merge to avoid having the develop changes as your own and so the PR validator won't block your PR for merge commits

ping @PrestaShop/committers waiting for feedback if im not missing something, before I start adding parent calls in every template which is missing it (and maybe if anyone knows any pages...

rebased again :heavy_check_mark: hopefully got fixed this time :smile:

> @PrestaEdit We can add > > `$this->setFieldsToUpdate(null);` > > somewhere around here: > > https://github.com/PrestaShop/PrestaShop/blob/434137b764ab0faa9de420a0a8ec54a039165dd0/classes/ObjectModel.php#L871 I agree, should be good :+1:

On the other hand, should we really reset the fields **before** the hook? Hook represents the action that was done, so in case the update() action was done with the...

> The multilang fields types changes for store ObjectModel is probably a BC break. Can you confirm? I think you only added missing type hints, but those fields were always...

Hi @sallemiines, the example-modules repository **contains multiple modules inside**, you don't need to rename the whole directory, but you need to take the corresponding module dir (the demo_grid) from the...

I see you probably have a file from wrong branch... Anyway, here i zipped the module and I checked that it works, could you try this? (you can install this...