Julius Žukauskas

Results 65 comments of Julius Žukauskas

**Bug**: - [ ] - `Order view page`. After adding product with invoice and a free shipping, the order totals are incorrect. (discount is added to reduce the relevant shipping...

> > This check is already done in PageVoter so we don't need to check in the annotation. > > Can you show me where ? smile I checked PageVoter...

PR description says its a migration of country list. (I suppose its a migration of create action?). Also fix the link which should be followed to reach the page. I...

In old form once you switch off field `"Does it need Zip/Postal code?"` the Zip code field is emptied. This behavior seems to be missing in your PR. Not sure,...

So I think it depends on one question - if we accept to remove the ability of having unlimited results in grids. Because that is exactly what we would achieve...

> For the issue 1, I would like the advice from https://github.com/orgs/PrestaShop/teams/product-team : The grid take the 100% width, cell auto adjusts on the content of data. These grid are...

> Hello @Progi1984, > > Thank you for your work! The issue is well fixed. The manual tests are ok. Just some [automatic tests](https://github.com/marwachelly/testing_pr/actions/runs/2782585481) are failed and we need a...

It requires some styling changes, because if the number is bigger, the refundable quantity div jumps down anyway. ![Screenshot from 2022-07-25 15-44-54](https://user-images.githubusercontent.com/31609858/180780353-e680862c-eb93-4921-b40d-d096fb71cfea.png) ![Screenshot from 2022-07-25 15-42-24](https://user-images.githubusercontent.com/31609858/180780199-3d1fa555-2c0b-4d04-9a1e-c146523fe7ed.png)

@PrestaShop/committers just a quckfix in front, but backend validation is still missing. Related code here https://github.com/PrestaShop/PrestaShop/blob/develop/controllers/front/CartController.php#L78 . (In issue case, the id_customization were 0 and it was saved that way...