PrestaShop
BO Migration Contact > Stores - Add command, command handler and behat tests for store adding
| Questions | Answers |
|---|---|
| Branch? | develop |
| Description? | BO Migration Contact > Stores - Add command, command handler and behat tests for store adding |
| Type? | improvement |
| Category? | BO |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | N/A |
| How to test? | Run behat test via : ./vendor/bin/behat -c tests/Integration/Behaviour/behat.yml -s store |
| Possible impacts? | N/A |
The multilang fields types changes for store ObjectModel is probably a BC break. Can you confirm?
This change is 
Hello @tom-combet!
This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!
Hi, thanks for this contribution!
I found some issues with the Pull Request description:
- Your pull request does not seem to fix any issue, consider creating one (see note below) and linking it by writing
Fixes #1234.
Would you mind having a look at it? This will help us understand how interesting your contribution is, thank you very much!
About linked issues
Please consider opening an issue before submitting a Pull Request:
- If it's a bug fix, it helps maintainers verify that the bug is effectively due to a defect in the code, and that it hasn't been fixed already.
- It can help trigger a discussion about the best implementation path before a single line of code is written.
- It may lead the Core Product team to mark that issue as a priority, further attracting the maintainers' attention.
(Note: this is an automated message, but answering it will reach a real human)
I'm really not sure about ValueObject class. It's however the most optimized way I found to do it.
Is it a problem to create a common ValueObject class? If so, I can move the validate method in PrestaShop Validator class for example. I see one drawback: if value object need Symfony Validator instance to perform more checks in other functions, it will be recreated.
Also, behat tests are not working, I need your help on this! CharacterCleaner is not injected when building TypedRegexValidator.
Hi guys, any news about it ? We need it to continue the migration process
Ping @PrestaShop/prestashop-maintainers & @PrestaShop/committers for a second review.
The multilang fields types changes for store ObjectModel is probably a BC break. Can you confirm?
I think you only added missing type hints, but those fields were always multilang (definition hasn't changed) no? so I'ts not a BC
Since we have had no news from you for more than 20 days, I'm closing this PR. Feel free to re-open it if you find the motivation to finish it. Don't hesitate to ping me if you have any questions or doubts.
