Julius Žukauskas

Results 65 comments of Julius Žukauskas

> I found additional issue so Im putting it on WIP again to avoid wasting QA time. As in screenshot bellow, the "clothes" has same parent and are identical so...

the **1st** issue is a bug (i'll try to fix it). Note for the 4th issue - the list is ordered by category id (so when the id is not...

okay, to be fair the roots of 1st issue is not coming from this PR. I managed to reprodue the same with old page. I created 2 new categories (catD...

https://github.com/PrestaShop/PrestaShop/issues/30219 created dedicated issue for 1st problem you mentioned. Sadly it seems to be too big to include the fix in my PR.

1 issue as I already mentioned before. (in product page v1 is the same, just try to save the product and you'll see the error that its missing the "default'...

please define how to test it, because the behavior of changed compared to old page.

Not blocking (can be improved later if accepted) - I wonder if we don't need some kind of empty state here (see screenshot). It could just be some simple text...

Found some fun stuff. You are currently showing all the catalog price rules, but it should only show the ones that affects the current product. For example if I add...

> @jolelievre if I remember correctly we decided that this should just list all catalog price rules? I hope not :thinking: IMO the whole point of showing them in product...

> Nothing critical, just some missing docblocks, so I approve heavy_check_mark Altough I just noticed Cs fixer is failing, so you could probably fix all those comments too.