Kat Marchán

Results 641 comments of Kat Marchán

Just to head this off... There are two places where we assign styles using JS: [[1](https://github.com/iron-vault-plugin/iron-vault/blob/main/src/characters/commands.ts#L206-L211)] [[2](https://github.com/iron-vault-plugin/iron-vault/blob/93e0815b094ba3c78872f039b53a1607950a673a/src/sidebar/moves.ts#L70)] We do this because the specific colors come from activated/dynamic rulesets (which will...

Fixed the lookbehinds, but I'd like to keep the `any` casts, because they're there for good reasons

/skip I’d like to keep the anys because they’re workarounds for external stuff

I've made all the requested changes, but I see the label's still there. Do I need to do anything else?

@joethei Thanks for taking the time to review! I know this isn't exactly a small plugin. Everything should be addressed as of 1.69.1.

As a general thought on performance: I don't consider extreme performance to be super important for the graphical renderer. It's kind of already assumed this is a "one and done"...

Oh it looks like you can include patterns: https://macromates.com/manual/en/language_grammars

I don't get the impression that Pygments uses existing parsers? I imagine UIs want to look more at something like the [TextMate](https://marketplace.visualstudio.com/items?itemName=kdl-org.kdl&ssr=false#review-details), [Sublime](https://packagecontrol.io/packages/KDL), or [Kate](https://github.com/larsgw/katepart-kdl) grammars. There's a v1 TreeSitter...

This is a pretty big, API-visible breaking change. While the refactor does seem nicer, do you have benchmark numbers on what difference they might make? The difference would need to...

I'm gonna sit on this for a bit. ssri has been fairly stable for a while and if I'm gonna put out a breaking change, I'd like to have more...