Kat Marchán comments

Results 641 comments of


                                            Kat Marchán

Perf: Replace with rustc_hash

where?

Perf: Replace with rustc_hash

Do you have any benchmarks about how this might affect orogene in particular?

how can i read source_back when call with_source_code before

You should be able to downcast any `Report` into a `dyn Diagnostic`, and then call `.source_code()` on it, to get the source code, if available.

Improve error reporting for boolean attribute syntax errors

I finally got some time to look at this and: this isn't the v2 parser doing this. It's the v1 parser. How are you parsing this file? Only KDL >6.0.0...

Use EditorConfig as for `autoformat`

I think I would consider editorconfig support in the main API itself to be out of scope. We don’t even deal with files! Where I do think it makes sense...

`result.replace("\n", "\r\n")` for `KdlDocument::to_string` on Windows

This should be functionality as part of `KdlDocument::fmt` &co. Since they're not configurable, I think a good default is "detect existing newlines and use the first one you find. Otherwise,...

`result.replace("\n", "\r\n")` for `KdlDocument::to_string` on Windows

Update: This is related to https://github.com/kdl-org/kdl-rs/issues/85 and should probably use the same strategy: allowing newline configuration with a `FormatConfig` object.

[v2] Correctly strip line continuations from trailing node formatting

...actually I'm not sure what this is about? I'll leave it open in case I find out later lol

[v2] Correctly strip line continuations from trailing node formatting

oh no yeah it's broken the test was just disabled

Incompatibilities KDL 2 <-> Query

uggghhh yes I thought I'd made them `q-ws+` already. It's very much written with the intention that you can use whitespace to disambiguate. And yes, as you say, `>> >>...