Steven Spriggs

Results 179 comments of Steven Spriggs

I need to revisit this. This PR got buried in other priority work. Need to investigate whether other changes to rh-card in the meantime haven't already resolved this issue.

> 2\. @eyevana does this affect cp-elements @eyevana I added you as a reviewer as a ping for this question.

with #2138 the horizon we may want to hold on this until those changes are merged as well.

Some feedback, the combo of scheme and color-palette pairing is confusing in the figma. Maybe some explaination will be helpful. `scheme:` can be defined by the browser "higher up" the...

Pinging @coreyvickery @marionnegp here as this is a design question. This was asked when ansible.com was being built. Currently the site is using 2 secondary nav's for its navigation stack,...

I'm not sure this is a thing anymore can we close? @markcaron Ansible doesn't use navigation-secondary and technically you can use the menu as a primary menu, although likely against...

@bennypowers @markcaron Should we close this PR? Seems like the idea is no longer something we are pursuing or warranted at this time.

Ok this will definitely shine light on the bifurcation between `*-lightdom.css` and `*-lightdom-shim.css`. Some older components like `navigation-secondary` will have to be revisited to split out CLS/FOUC driven lightdom styles...

> @bennypowers, can you explain what changed visually? @marionnegp, everything in the `` tag should fade in/out when you navigate to a new page, smoothing out the page load a...