Steven Spriggs

Results 179 comments of Steven Spriggs

Arrows issue looks to be related to a safari bug of incomplete implementation of `::marker` psuedo. Might have to rethink the way this is implemented. https://bugs.webkit.org/show_bug.cgi?id=204163

Columns shifting look to be the built in browser styles for focus causing a recalculation of the spacing needed for the columns. I'll see if I can work around this....

> This should get a major changeset because the label API changed, no? unless i'm mistaken and we already did that You are correct we changed the label API by...

If a keyboard user is able to open the menu, then a mouse click should do the same. BOTH shouldn't be able to select a sub item.

> we may choose not to implement this, if this is simply an implementation detail of modal There is an implementation of the backdrop that does have a spinner http://v4-archive.patternfly.org/v4/components/backdrop/react/with-spinner/...

I need to revisit this old PR and see what is still applicable.

Related possible future state css: https://developer.apple.com/videos/play/wwdc2023/10121/?time=238

> it's not clear to me that this can be done from the shadow root. This was my findings, unfortunately just no way of doing it given complex selectors not...

> * [ ] Fix v1/v2 toggle to be consistent in style > * [ ] Have v1/v2 toggle go directly to All Components (not individual components) I believe we...