Steven Spriggs
Steven Spriggs
PR: https://github.com/patternfly/patternfly-elements/pull/2099
@bennypowers On fresh install when loading label demo. ``` Uncaught DOMException: Failed to execute 'define' on 'CustomElementRegistry': the name "pfe-button" has already been used with this registry at http://localhost:8001/node_modules/@lit/reactive-element/decorators/custom-element.js:6:80 at...
> > Also primary-detail. > Correction primary detail looks to be a seperate issue with the demo/pfe-primary-detail.js: ``` Error while transforming elements/pfe-primary-detail/demo/pfe-primary-detail.js: Top-level await is not available in the configured...
lightdom.css also doesn't appear to be loading for the components that have it linked in their demos: ``` GET http://localhost:8000/elements/pfe-primary-detail/pfe-primary-detail--lightdom.min.css net::ERR_ABORTED 404 (Not Found) ``` ``` GET http://localhost:8000/elements/pfe-card/pfe-card--lightdom.min.css net::ERR_ABORTED 404...
> Ran the tests locally and everything looked good from my end, all the components built and looked correct on their docs pages. @zeroedin - Can you confirm whether or...
@bennypowers `pfe-autocomplete` also has a dependency on `pfe-button`, we should add it to it's package.json as well. Otherwise this looks good to go.
Superseded by pfe-tabs 1:1 #2099 which includes horizontal overflow scrolling
@mwcz Yes, at the time of this writing it believe it was my misunderstanding of how the `customColors` was intended to work. I think when you and I talked over...
This sounds like a much more maintainable idea to me. I like it.
> @zeroedin you still want this one? Sure, I can take a stab at it.