patternfly
fix(button)!: remove BaseButton
Closes #2616
What I did
- remove basebutton
Testing Instructions
- check dp against prod demos
Notes to Reviewers
- see PR in rhds
- @eyevana does this affect cp-elements
- don't merge until 2.5.0 is release with all non-breaking feats in queue merged
🦋 Changeset detected
Latest commit: 72b11ec19973eb0f9248a9a5fc7d0ff08e4c98b1
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| @patternfly/elements | Major |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploy Preview for patternfly-elements ready!
| Name | Link |
|---|---|
| Latest commit | 2fafd1afe5f9f81e2d3a0412b88b3d6e61ea0b7c |
| Deploy Preview | https://deploy-preview-2631--patternfly-elements.netlify.app/ |
To edit notification comments on pull requests, go to your Netlify site settings.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
2. @eyevana does this affect cp-elements
@eyevana I added you as a reviewer as a ping for this question.
@bennypowers @zeroedin cp-elements isn't using any of the Base* classes, so no dependency from that end.
