zehata

Results 18 comments of zehata

I wanted to refactor the style class names to use `left` or `right` instead of `preReq-` so that it is easier to understand, but that is beyond the scope of...

Re: https://github.com/nusmodifications/nusmods/pull/3840/files#diff-c16227ad8088f0a3a8edf1ae53344bb0189198cb956157ec0a9083cf3e7069f9L106-L112 The code originally had `prereqNode` class on conditional nodes. As far as I understand, modules don't conditionally unlock other modules, i.e. there are no situations like so: ```...

Update: I have a working copy of a version with a toggle in settings, but I am still refactoring. See preview at temporary branch https://github.com/zehata/nusmods/tree/zehata/website-module-page/3202/toggleable-left-to-right-prerequisites-trees-wip ![image](https://github.com/user-attachments/assets/668fb686-7a6d-4e67-b39c-bc2c361a4267) ![image](https://github.com/user-attachments/assets/721e5881-65c2-42ab-b4b6-f48e34c6c7b1)

Reverted to draft because of ![image](https://github.com/user-attachments/assets/81ad100a-505c-48b7-bca6-2b209b0c4388) Update: Looks like it was already like this, just not visible when it was on the right. Fixed regardless. ![Screenshot 2024-10-23 194618](https://github.com/user-attachments/assets/d2310077-0a9d-4818-9284-4fce8d88b153)

Toggleable implementation extending this PR is at #3842. **Please note that the branch in that PR diverges from this branch and cannot both be merged.**

I found this bug report on the same issue: https://bugs.launchpad.net/ubuntu/+source/vala-panel-appmenu/+bug/2107638 Linking it for reference

Also, while doing testing, I realized that the error occurred before writing to state, so users' configs were actually not overwritten. Nonetheless, I think it would make more sense to...

Looks like it's caused by FIN2704 being an available module, which wraps it in a button that is invisible ![image](https://github.com/user-attachments/assets/8228a00c-a69a-4673-a904-05e5a1e866ef)