zehata

Results 23 comments of zehata

FIN2704 is an active mod that links to FIN2704/FIN2704X, so `getModuleCondensed("FIN2704")` is truthy but `moduleActive` for FIN2704 is falsey (name is not exact match). This causes the node to be...

@Jiwei99 Something like this? I agree with you that this solution seems the cleanest, since it is more consistent with mods that don't use wildcard prerequisites. ![image](https://github.com/user-attachments/assets/2aff8fe2-9fd1-4681-86ed-d2cafc08c246) However, I noticed...

Alternatively: ![image](https://github.com/user-attachments/assets/2c70b119-8a6a-4631-b087-efc68795523f)

The grade requirement is only shown when it is not the default 'D' grade.

I think it is an edge case in which prerequisites don't use the default 'D' passing grade AND use the "Courses starting with" pattern. So I think that is not...

It is possible to do this, but it's possible that situations like this will happen, which might appear messy to some people? (I think it's fine though). If it's possible,...

Also @ core team, an alternative is to update ANTLR to branch when encountering wildcard modules instead of appending % when scraping, which is a cleaner implementation but will also...

@ravern Sorry about the long silence, I wasn't paying attention to this because exam season and also my github notifs aren't working for some reason...

~I have noted the codecov report and will work on those. However, it should not impact the implementation.~ Fixed by [9be978c](https://github.com/nusmodifications/nusmods/pull/3842/commits/9be978c1cc43ccc4614f3fc6854d0496bc734c76) and [bd7c8aa](https://github.com/nusmodifications/nusmods/pull/3842/commits/bd7c8aa6e51e53a75b0866b9dbab5838022c7bc0)

[bd7c8aa](https://github.com/nusmodifications/nusmods/pull/3842/commits/bd7c8aa6e51e53a75b0866b9dbab5838022c7bc0) is technically outside the scope of this PR, but if it makes codecov happy then so be it.