Zeeshan Ali Khan

Results 435 comments of Zeeshan Ali Khan
trafficstars

> * https://github.com/ironcladlou/openshift4-libvirt-gcp/blob/master/tools/create-cluster#L23 This one is not needed any more. I think the line numbers have changed. Could you point out which part you meant?

> I have looked a bit how to implement this, would that be an interesting feature to have? Maybe but what's the use case?

In GitLab by @bilelmoussaoui on Sep 12, 2020, 23:10 Well, the dbus interface complains about having a list of buttons that's empty. Not serializing if the Vec is empty makes...

In GitLab by @bilelmoussaoui on Sep 12, 2020, 23:16 I wonder if this issue & this one https://gitlab.freedesktop.org/zeenix/zbus/-/issues/32 are similar/duplicates

> Well, the dbus interface complains about having a list of buttons that's empty Sounds like a bug in the dbus service. Having said that, if we can support this...

> I wonder if this issue & this one https://gitlab.freedesktop.org/zeenix/zbus/-/issues/32 are similar/duplicates That's similar but not exactly duplicate. That one is more about just skipping the field entirely and would...

In GitLab by @bilelmoussaoui on Sep 12, 2020, 23:37 I will wait till the skip attribute is implemented, I don't think adding an extra skip_serializing_if would complicate the code. I...

> I don't think adding an extra skip_serializing_if would complicate the code. Good. Just for the record, I wasn't implying it necessarily would. I was just clarifying my requirement for...

Hey Yosh, You've discussed this before with me but I'm afraid I'm still not 100% clear on the use case. Would it be to combine this crate with async-channel so...

> But if for whatever reason both are used interchangeably, that shouldn't fail. As I wrote, > given that sender can't really decide which receiver gets the message, I can't...