Zeeshan Ali Khan

@elmarco cool but no hurry. I didn't plan to work on this soon. Just didn't want to forget about it.

Hmm.. Given we already have quite a few subcrates, I would rather avoid creating yet another one. Can't zvariant_derive expose the needed utils API and zbus_macros can depend on it?...

In GitLab by @turbocooler on Feb 14, 2023, 22:59 Makes sense. I'll make a MR with this change then. Won't exporting utility macros from the root of zvariant_derive be a...

> Makes sense. I'll make a MR with this change then. Awesome! > Won't exporting utility macros from the root of zvariant_derive be a concern? Yeah, best we export in...

In GitLab by @turbocooler on Feb 15, 2023, 13:23 I've tried experimenting with it and turns out declarative macros can not be exported from proc macro crates. Here's the error...

> I don't think generating these structures with attributes using proc macros makes sense. Right. I don't then know what could be the best solution. We face a similar issue...

In GitLab by @turbocooler on Feb 16, 2023, 20:11 Is there a reason you wouldn't like to add another crate? I feel like these two situations are good enough reasons...

> Is there a reason you wouldn't like to add another crate? Well, mostly greater cognitive load and harder to maintain. I am not sure how long you intend to...

In GitLab by @turbocooler on Feb 17, 2023, 15:41 > Well, mostly greater cognitive load and harder to maintain. The reason behind the attribute-related changes I recently submitted to `zvariant_derive`...

> believe that moving attribute parsing logic into a separate module/crate makes the code that does the actual code generation more visible and easier to work with. When you are...