zariiii9003

Results 154 comments of zariiii9003

@lumagi What do you think about adding `CanProtocol.CAN_FD_NON_ISO`?

I don't see much difference in the logic. Maybe the messages remain in the transmit buffer a little longer, or the PCAN driver takes longer to signal the windows event...

Thanks for trying! I guess the performance is not limited by python then.

@hiteshhedwig I rebased and fixed the mypy issues. You should include the new parameter in the docstring and add some test.

@Tian-Jionglu Are you still working on the tests? I cannot merge if the tests are failing.

The ASC tests are still failing.

`canSetAcceptanceFilter` sets the hardware filtering in the kvaser driver. If you set `self._is_filtered = False` then the *python-can* software filtering is used instead as a fallback. But i cannot say...

Could you try PR #1796 ?

You should format your code with black to make the tests pass. Otherwise this looks fine. It's outside of the scope of this PR, but you could add the `timing`...

> @zariiii9003 I think this is ready for scrutiny. I will check this on the weekend since this is rather big. Thank you for your great effort!