python-can icon indicating copy to clipboard operation
python-can copied to clipboard

implement TRCWriter feature for v1.1

Open hiteshhedwig opened this issue 2 years ago • 1 comments

current TRCWriter does not implement method for fileversion 1.1. So i have implemented it. And trc can be generated as follows

;$FILEVERSION=1.1
;$STARTTIME=45248.7383051968
;
;   Start time: 18-11-2023 17:43:09.569.0
;   Generated by PCAN-View v5.0.1.822
;
;   Message Number
;   |         Time Offset (ms)
;   |         |        Type
;   |         |        |        ID (hex)
;   |         |        |        |     Data Length
;   |         |        |        |     |   Data Bytes (hex) ...
;   |         |        |        |     |   |
;---+--   ----+----  --+--  ----+---  +  -+ -- -- -- -- -- -- --
     1)         2.6  Rx         0020  8  80 00 A0 06 68 03 3A 00 
     2)         3.2  Rx     18DAF101  8  10 18 62 02 2F 81 90 02 
     3)         4.7  Rx     18DA01F1  8  30 0A 0A 55 55 55 55 55 
     4)        11.7  Rx     0C0AA7F0  8  00 00 00 00 00 00 00 00 

Please feel free to leave any feedback

hiteshhedwig avatar Dec 06 '23 15:12 hiteshhedwig

@hiteshhedwig I rebased and fixed the mypy issues. You should include the new parameter in the docstring and add some test.

zariiii9003 avatar Jan 14 '24 13:01 zariiii9003