python-can icon indicating copy to clipboard operation
python-can copied to clipboard
verified publisher icon hardbyte

Apply asc format since format v8.1

Open Tian-Jionglu opened this issue 2 years ago • 4 comments

A solution to solve issue #1531.

Mainly include 2 changes in ASCReader class:

  1. extract header when initial ASCReader, to get correct start_time, version, date, etc before iterate the messages. I think this is necessary;
  2. new function _process_fd_can_frame_2 to process CANFD message in ASCFormat since V8.1;

Remaining issue: some tests can not pass, mainly because after the change, correct absolute timestamp is get when iterate the messages;

Tian-Jionglu avatar Aug 03 '23 10:08 Tian-Jionglu

@Tian-Jionglu Are you still working on the tests? I cannot merge if the tests are failing.

zariiii9003 avatar Aug 24 '23 09:08 zariiii9003

Commits to parse the ASC format version using packaging. Jobs in working: change ASC format test to adjust absolute time.

Tian-Jionglu avatar Nov 01 '23 08:11 Tian-Jionglu

The ASC tests are still failing.

zariiii9003 avatar Dec 01 '23 17:12 zariiii9003

When diving into test example, i found my mistake at the start. The symbolic name issue is not only related to ASC format version. In fact, SymblicName works for symbolic logging at first place. I'm still looking for example about symblic logging.

I would close this PR in coming days, and start a new PR to inherit the change to fix absolute time in ASC format. If there is already support about symbolic logging in python-can, please give me a hint.

Tian-Jionglu avatar Dec 03 '23 07:12 Tian-Jionglu

see PR #1788

Tian-Jionglu avatar Jun 11 '24 01:06 Tian-Jionglu