Yusuke Wada comments

Results 1706 comments of


                                            Yusuke Wada

feat(types): make Hono client's $url return the exact URL type

Sorry for being late. Anyway, this change is not a "fix", but a "feat". It's a new feature.

feat(types): make Hono client's $url return the exact URL type

@miyaji255 This is awesome! We can include this feature in the next minor release. So, I'll merge when preparing to release it. Thank you!

Downstream methods without `path` args break upstream method path typing

@ambergristle Thanks. This is a bug.

docs(jwk): clarify what the JWK middleware validates

@surajkewat72 Thank you for the PR. I think we have to prioritize updating the website: https://hono.dev/docs/middleware/builtin/jwk , instead of adding a lot of description to JSDoc.

route/mount should also accept middlewares

Hi @tcurdt Indeed, as you said, if the `app.route()` and `app.mount()` can receive middleware, it will be useful in some cases. However, we don't have a plan to implement it...

route/mount should also accept middlewares

> Just curious - what makes it more complex than `get` and friends? shouldn't it follow the same pattern? Yes, it's the same pattern. But it will be like an...

feat(secure-headers): Add CSP report-uri directive support

@cruzz77 Thank you for the proposal. Hey @watany-dev ! The author of the secure-headers. What do you think of this?

Fragment identifiers cause incorrect route parameter parsing in Service Worker

Ignoring the fragment in `getPath` by default is expected behavior, now. So, it's not an actual bug. I'll remove the triage label and add an `enhancement`.

feat(secure-headers): Add CSP report-to and report-uri directive support

Hey @cruzz77 ! Looks good to me. I'll merge this later and include this change in the next minor release. Thank you for your contribution!

Supporting auotmatic generation of `AppType` from `routes` folder

This is super interesting. I'll work on it if I have time. Thanks!