Yusuke Wada comments

Results 1706 comments of


                                            Yusuke Wada

Proxying compressed response do not work out of the box

I can found that overriding `fetch` in `@hono/node-server` causes the problem: https://github.com/honojs/node-server/blob/cd4d4d7a6d33532713086c2e896d133dc5f5e3e5/src/globals.ts#L14 As a result, the following works well: ```ts import { Hono } from 'hono' import { serve }...

Proxying compressed response do not work out of the box

@usualoma Thank you for the explanation! It's okay to remove the `Accept-Encoding` header from `fetch` when it accesses the origin. @haochenx So, I think the following code is simple and...

Proxying compressed response do not work out of the box

Ah! Or, instead of it, making "Proxy Helper" sounds good! ```ts import { proxyFetch } from 'hono/proxy' ```

Proxying compressed response do not work out of the box

We can close this issue because we now have the Proxy Helper. Thanks!

fix(types): replace schema-based path tracking with VoidMiddlewarePath parameter

Hi @kosei28 Thank you for your work! I want to take a look at this deeply, but I'm a little busy. Though I said "please help me", I can't work...

fix(types): replace schema-based path tracking with VoidMiddlewarePath parameter

Hey @kosei28 ! Sorry for being late. Awesome! Let's go with the `VoidMiddlewarePath` approach. I've left some comments. Please check them.

fix(types): replace schema-based path tracking with VoidMiddlewarePath parameter

@kosei28 Ah, you are right! The `CurrentPath` approach is best. The problem was that types did not know the "current path". Let's go with it.

fix(types): replace schema-based path tracking with VoidMiddlewarePath parameter

@kosei28 Looks good! You solve the big problem. Awesome. Thank you for your contribution!!

fix(types): replace schema-based path tracking with VoidMiddlewarePath parameter

I'll merge this to the `next` branch for the next minor version and release it soon.

basePath has no effect on app created by honox createApp

Hi @monim67 Currently, you can't specify the base path with your method. You can specify the base path with setting the `app` option of `createApp()`: ```ts import { Hono }...