Yusuke Wada

Results 1706 comments of Yusuke Wada

Hi @riywo ! > My point here is that there is no concept like scope of npmjs on deno.land/x. So, we can't secure a package name for a new middleware...

Hi @rishavs ! Thank you for your comment. Are `app.notFound` and `app.onError` not enough? Indeed, Hono does not have the original Error objects. ```ts // https://honojs.dev/docs/api/hono/#not-found app.notFound((c) => { return...

> I don't think they are documented anywhere right now. Yes, it is not well documented. We have to write better, cc: @ThatOneBro :)

@rishavs Helmet would be nice. Body parser and cookie parser are already included in the core. ```ts // Parse cookie app.get('/entry/:id', (c) => { const value = c.req.cookie('name') ... })...

Hi @mashaal ! Thank you for creating the issue. The internal implementation has been changed, indeed. Could you write down your code or short snippets to reproduce it?

In a general use case it is working correctly. First, we have to reproduce the condition that does not work.

I think this `content-type` issue: > Setting context.header("Content-Type", "text/css"); still returns "text/plain" content-type headers. and problems that @that-ambuj said are different things. Because the internal implementation has changed since 2.1.4....

I believe the Content-Type issue is due to this change. The default Response was specified as `text/plain` because of this change. https://github.com/honojs/hono/commit/24a28942de1cd4ae8e2c8794830950b35de712bd#diff-0cd594dddd6a9f2e3e26afebbb92716434437d7001c2416252aa7531e7f2b8d4R95

Hmm. It works correctly. ![SS](https://user-images.githubusercontent.com/10682/193305939-38924db0-139c-46b5-bdef-27626d7d4436.png) ![SS](https://user-images.githubusercontent.com/10682/193305981-da8893f3-e2ac-4091-b5d6-561938c7b46a.png)