Yusuke Wada comments

Results 1706 comments of


                                            Yusuke Wada

Let app.onError handle non-Error instance

It's not a bad idea to put a thrown non-error value to `Error` like the comment: https://github.com/honojs/hono/issues/667#issuecomment-3301249718 But, I do not feel good that it will all be an `Error`...

Let app.onError handle non-Error instance

Hi @usualoma I'd like to know the explanation of https://github.com/honojs/hono/issues/667#issuecomment-3301291099 > Ah, but fundamentally, in cases where non-Error objects are thrown, I believe the best practice is to handle them...

Let app.onError handle non-Error instance

@usualoma I also think `UnknownError` is not the best. But making the class extend `Error` is useful because the user can determine if it's a pure error or not by...

Let app.onError handle non-Error instance

Hi @usualoma I'm still thinking about this issue. > However, (in my opinion) this case is, as the name `UnknownError` suggests, an error where “Hono doesn't know what it is,”...

Let app.onError handle non-Error instance

Opps. Accidentally, I closed. Reopened.

fix(types): correct types when middleware return Promise<void>

The issue was resolved by https://github.com/honojs/hono/pull/4552. Closing.

Support Escaping Colons in Routes to Allow Google-Style Custom Methods

To enable this feature, we have to change the implementation of the routers entirery. It's difficult.

feat(timing): add wrapTime to simplify usage

Hi @PassiDel This is a good feature! Looks good to me. I'll merge this later and include the feature in the next minor version `4.11`. Thank you!

try catch cloudfront event -> request mapping for lambda@edge handler to avoid undefined access errors

@dwm-mcollins Thank you for proposing. Hey @watany-dev Do you have any thoughts about this?

feat(types): make Hono client's $url return the exact URL type

Hi @miyaji255 This is super interesting. I'll look at it deeply later.