Nick Young
Nick Young
I agree that we should try and reduce stuttering when reading the actual call sites.
We use it in mainline Contour, so I'm supportive.
Thanks for opening this issue @george-zubrienko. I agree that the connectivity tests should disable IPv4 tests completely when IPv4 is disabled - I don't think our tests cover this very...
One hundred percent agreed on trying to do something else with the list of features - ideally we would read this out of the Go source files for the test...
/hold for other review though
Yeah, I like these changes, with the small exception of moving to SHOULD - RFC language is clearer for both implementations and users.
LGTM with the SHOULD changes.
Yes, each implementation will need to update to support v1.1, which for Cilium will require supporting both v1 and v1alpha2 of GRPCRoute. Until then, Cilium only supports v1.0 of Gateway...
I opened cilium/cilium#32539 to cover building out support for Cilium that's similar to what @howardjohn described for Istio.