gateway-api icon indicating copy to clipboard operation
gateway-api copied to clipboard

Update GEP-1762 with Gateway name limit recommendations

Open sunjayBhatia opened this issue 1 year ago • 7 comments

What type of PR is this?

/kind cleanup /kind documentation /kind gep

What this PR does / why we need it:

Updates GEP-1762 to provide guidance for implementers on what to do with the gateway.networking.k8s.io/gateway-name (to be put on generated in-cluster resources) when a Gateway's name exceeds 63 characters (the label value length limit).

Also updates Gateway resource to recommend users create Gateways with <= 63 character names.

Which issue(s) this PR fixes:

Fixes #2592

Does this PR introduce a user-facing change?:

Gateway names are recommended to be no longer than the maximum label value length of 63 characters to ensure compatibility with in-cluster implementations which set the Gateway name as a label on generated resources.

sunjayBhatia avatar May 09 '24 20:05 sunjayBhatia

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arkodg, robscott, sunjayBhatia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 10 '24 22:05 k8s-ci-robot

Thanks @sunjayBhatia! Let's give a few days for @youngnick to look at this in case he has better ideas for where this guidance could go. If not, I'm fine with some lazy consensus where we can just remove the hold sometime next week if no strong opinions emerge.

/lgtm /approve /hold for second opinion

any further thoughts on this @robscott @youngnick

sunjayBhatia avatar Jul 09 '24 16:07 sunjayBhatia

Yeah, I like these changes, with the small exception of moving to SHOULD - RFC language is clearer for both implementations and users.

youngnick avatar Jul 11 '24 02:07 youngnick

LGTM with the SHOULD changes.

youngnick avatar Jul 11 '24 02:07 youngnick

@sunjayBhatia the PR is in a pretty advanced state, are you still interested in moving this forward?

mlavacca avatar Aug 19 '24 17:08 mlavacca

@sunjayBhatia: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gateway-api-crds-validation-4 1c63e0541f4edc6654433fcae8fff73e58010f46 link true /test pull-gateway-api-crds-validation-4

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

k8s-ci-robot avatar Sep 10 '24 20:09 k8s-ci-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Oct 18 '24 13:10 k8s-triage-robot