Update GEP-1762 with Gateway name limit recommendations
What type of PR is this?
/kind cleanup /kind documentation /kind gep
What this PR does / why we need it:
Updates GEP-1762 to provide guidance for implementers on what to do with the gateway.networking.k8s.io/gateway-name (to be put on generated in-cluster resources) when a Gateway's name exceeds 63 characters (the label value length limit).
Also updates Gateway resource to recommend users create Gateways with <= 63 character names.
Which issue(s) this PR fixes:
Fixes #2592
Does this PR introduce a user-facing change?:
Gateway names are recommended to be no longer than the maximum label value length of 63 characters to ensure compatibility with in-cluster implementations which set the Gateway name as a label on generated resources.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: arkodg, robscott, sunjayBhatia
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [robscott]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Thanks @sunjayBhatia! Let's give a few days for @youngnick to look at this in case he has better ideas for where this guidance could go. If not, I'm fine with some lazy consensus where we can just remove the hold sometime next week if no strong opinions emerge.
/lgtm /approve /hold for second opinion
any further thoughts on this @robscott @youngnick
Yeah, I like these changes, with the small exception of moving to SHOULD - RFC language is clearer for both implementations and users.
LGTM with the SHOULD changes.
@sunjayBhatia the PR is in a pretty advanced state, are you still interested in moving this forward?
@sunjayBhatia: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-gateway-api-crds-validation-4 | 1c63e0541f4edc6654433fcae8fff73e58010f46 | link | true | /test pull-gateway-api-crds-validation-4 |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle rotten - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten