Nick Young

Results 382 comments of Nick Young

Well, in the spec for backendRef, the above behavior is mandated (that is, if there are multiple backends, and one is invalid, then the invalid one should instead produce an...

I agree that we should create another issue for the test Mike described.

I think we should recommend pretty strongly against using a Service of type ExternalName as a backendRef. It's just too easy to bypass namespace controls by using ExternalNames of `service.namespace.svc.cluster.local`,...

Yes, I agree that is a useful use case, but allowing Service of Type ExternalName in all cases still leaves us with the ability to use this functionality to bypass...

I can't see a reason not to support the local filesystem, subject to the usual input-validation checks to prevent directory traversal.

I can't find any good examples in a quick scan, but even just doing the obvious stuff is an improvement (no more than one consecutive dot allowed in paths and...

Yup, I think this is good to go. /lgtm

@anjuls, the webhook is required to do more specific validation of Gateway API resources. Without it, there are cases in which you'll supply invalid objects, that may or may not...

I've reopened the issue for now, I really would like to hear more about what went wrong when you tried to install; we don't have much information about actual usage...

/lgtm /hold for @bowei's feedback though.