Yonatan Karp-Rudin comments

Repositories
Issues
Comments

Results 5 comments of


                                            Yonatan Karp-Rudin

Visitor pattern code example violate SOLID

By the way, happy to pick this fix up if you all agree that this is indeed an issue 😄

Visitor pattern code example violate SOLID

After reading a bit deeper about this design pattern in multiple sources (see below), it seems like the design itself is (almost) correctly implemented, but the example is confusing. In...

Prototype pattern re-factor

There's a pr for the fix, but it seems that SonarCloud isn't happy with the try-catch of the `clone` in terms of coverage. From checking online, it's considered anti-pattern to...

fix issue 1968 and correct visitor pattern code and test.

Hi @xyllq999 please keep in mind that the README code needs to be updated as well

Update JVM version to the latest stable release

Couple more thoughts: * I think that we can also remove Lombok with this upgrade, as 99% of the functionality it provides is available in a `Record` class now. *...