java-design-patterns icon indicating copy to clipboard operation
java-design-patterns copied to clipboard

fix issue 1968 and correct visitor pattern code and test.

Open xyllq999 opened this issue 2 years ago • 2 comments

This PR helps for solving #1968

fix issue 1968 and correct visitor pattern code

Modified issue with visitor mode code, changed different method name to method reload, fixed issue1968.

Pull request description

The main modification of the method in the class is visit, which is accessed only by different parameter types, eliminating some errors and simplifying code writing, in line with the pattern requirements.

xyllq999 avatar Sep 10 '22 15:09 xyllq999

Hi @xyllq999 please keep in mind that the README code needs to be updated as well

yonatankarp avatar Sep 11 '22 08:09 yonatankarp

Many thanks for implementing this improvement @xyllq999! Kudos to @yonatankarp for raising the issue and providing review help.

iluwatar avatar Sep 25 '22 18:09 iluwatar

@all-contributors please add @xyllq999 for code

iluwatar avatar Sep 25 '22 18:09 iluwatar

@iluwatar

I've put up a pull request to add @xyllq999! :tada:

allcontributors[bot] avatar Sep 25 '22 18:09 allcontributors[bot]

@all-contributors please add @yonatankarp for review

iluwatar avatar Sep 25 '22 18:09 iluwatar

@iluwatar

@yonatankarp already contributed before to review

allcontributors[bot] avatar Sep 25 '22 18:09 allcontributors[bot]