yearn-vaults
yearn-vaults copied to clipboard
yearn
Yearn Vault smart contracts
Candidate for next release. Do not merge until it's ready for a release. Change Log: - Remove balanceOf dependency for estimatedTotalAssets (airdrop protection) - allow harvest on same block as...
Currently have linting for Python and Solidity files, but not Vyper. Add linting support + hook up to Github workflows.
afterBal should be changed to deposited https://github.com/yearn/yearn-vaults/blob/b3f33bd5a8ece52b6504d0c1cd9029fb639d6349/contracts/BaseWrapper.sol#L182 also, pull boolean should be immutable, not sure there is a usecase for both pull and non-pull deposits
Need to see when OpenZeppelin upgrades see: https://github.com/yearn/yearn-vaults/pull/502
it's not the best UX when you desire to withdraw 100 shares that it will only consume 50. should add `minShares` as a parameter and revert if it cannot fill...
There are possible optimizations that can be done on harvest/report flow: Notes from @Grandthrax ``` If we can find a way to report profit with having to withdraw from underlying...
related to #404 The fuzzing case would be similar to others in the tests/integration/ section. This section of Brownie's docs will help: https://eth-brownie.readthedocs.io/en/stable/tests-hypothesis-stateful.html
- [ ] Add a strategy (by address, using pre-defined params w/ overrides available) - [ ] Update params for strategy (single parameter or multiple params at once) - [...
From audit: "Callbacks. Some token standards, e.g. ERC223, ERC721, and ERC777, define callbacks. Some of these callbacks can be invoked upon regular “transfer” calls. This creates a significant security risk...